User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
Admin
On this account I’m primarily posting dev log updates for Iceshrimp.NET.
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
Right, so far today we’ve fixed:
- A DbContext use-after-dispose causing background user refreshes to fail
- A race condition causing multiple user refreshes to be queued simultaneously
- Bugs in the activity content type validation (it was too strict & didn’t accept some less common valid ones)
- A bug where the home timeline heuristics query would fail if the database had not been populated with notes yet
- A bug where the http signature signing string wouldn’t sign headers that occur more than once correctly

We’ve also
- Bypassed a
GTS bug
- Added a User-Agent header to
all outgoing HTTP requests, not just signed ones
- Improved debug logging in some places
1
0
3
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
@eta your avatar federated as {"error": "I'm a teapot: no user-agent sent with request”}, is that intentional? x)
0
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
Having working edits is really nice.
0
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
Though, hmm. I’m already validating the host & content type, so I’m not sure if this would actually help in any way, and I’m not sure increasing complexity is a good idea here.
1
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
I already did some security hardening, and will continue that now! - We should re-fetch activities if the activity id doesn’t match the queried URL.
1
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
Good morning everyone, time to get some work done! >w<
1
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
that’s a lot of things! I’m gonna have dinner and go to sleep now. More work to do tomorrow!
0
0
5
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
Yawn! Long day. Today I fixed several security vulns in the JS codebase, added support for follow requests, invite code generation, handlers for user updates, handlers for incoming note edits, outgoing note edit federation & note edit notifications.
1
0
3
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
oh, and I almost forgot: I fixed the most recent masto vuln in iceshrimp.net as well, I had already implemented some safeguards against this a couple weeks ago but I made them even stricter now
0
0
4
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
I also made some tweaks to the follower/following counters so that they are more accurate (there’s functions to recalculate them now, should I have missed any discrepancies)
1
0
1
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
speaking of: I just implemented the ability to generate invites (if you’re an admin), as well as accepting & rejecting follow requests

I also overhauled the follow/follow-request notification system so that it prunes old notifications when they’re superseded by a new action, which the database will appreciate for sure
1
0
1
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
aight, I created a new account (@test) for spammy stuff, and will only post updates on this account from now on
1
0
2
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
holy shit, the mona timeline catchup bug seems to simply not be present in this, big if true
0
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
update: fixed some more bugs. now i’m actually going to bed.
0
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
@eater glad it’s not the actual mention logic, I worked hard on that and thought it was sound ^^
0
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
@eater yeah, that + a second mistake in very similar code fixed it ^^
1
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
@eater oops.
1
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
@eater actually, it seems to be the notification renderer ​:thinking:​
1
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
@eater lol, lmao: it’s mona that broke. db entry & api responses are correct x)
1
0
0
0
User avatar
zotan (.NET edition) shrimp2 @zotan@next.e2net.social
2y
@eater unrelatedly: oops, you broke the mention parser (or mona?) with that post x)

I’ll look at it tomorrow.
1
0
0
0